Skip to content

Update Chinese#13

Merged
bossanova808 merged 7 commits intobossanova808:mainfrom
wabisabi926:main
Apr 27, 2026
Merged

Update Chinese#13
bossanova808 merged 7 commits intobossanova808:mainfrom
wabisabi926:main

Conversation

@wabisabi926
Copy link
Copy Markdown
Contributor

@wabisabi926 wabisabi926 commented Apr 23, 2026

Summary by CodeRabbit

  • Localization
    • Added Simplified Chinese translations for the add-on summary, description and UI strings; introduced zh_CN metadata so Chinese appears in add-on listings and settings.
  • Documentation
    • Translated README content into Chinese, including feature descriptions and optional behavior explanations.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@wabisabi926 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 59 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1ca42ba0-ad2a-486d-a2aa-859243edabd0

📥 Commits

Reviewing files that changed from the base of the PR and between 8043c14 and 2a7ffb5.

📒 Files selected for processing (2)
  • README.md
  • addon.xml
📝 Walkthrough

Walkthrough

This pull request adds Simplified Chinese (zh_CN) localization by translating README.md to Chinese, updating addon.xml to include zh_CN summary/description (and modifying sv_SE), and adding a new resources/language/resource.language.zh_cn/strings.po file with Chinese translations for the add-on UI and settings.

Changes

Cohort / File(s) Summary
Documentation localization
README.md
Translated README content from English to Chinese: add-on description, optional behaviors, support thread reference, and maintenance/history note.
Add-on metadata localization
addon.xml
Replaced/updated metadata block to add zh_CN localized summary and description alongside en_GB and sv_SE; modified sv_SE description content.
Language resource file
resources/language/resource.language.zh_cn/strings.po
Added new Simplified Chinese gettext file with translations for addon summary/description, resume settings, autoplay options, exclusions, and related UI strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Adding Swedish translation #11 — Adds/updates localization metadata and language resource files (Swedish), overlapping with this PR's localization changes.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "Update Chinese" is vague and non-descriptive. While it relates to the changeset, it lacks specificity about what aspect of Chinese localization is being updated. Revise the title to be more specific, such as "Add Chinese (Simplified) localization for playback resumer addon" or "Update Chinese translation files and metadata".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@addon.xml`:
- Line 16: Replace the incorrect phrase "återuppspela punkten" in the addon
metadata string with the correct Swedish term used elsewhere (e.g.
"återupptagningspunkten" or "återupptagningspunkt") so the sentence reads
consistently as "resume point"; locate the phrase in the metadata block (the
text containing "Körs som en tjänst...") and update only that token to match the
project's existing Swedish PO wording.

In `@README.md`:
- Line 9: Update the README sentence describing the optional autoplay feature to
preserve the original condition from the localized setting: say the random
autoplay occurs "if nothing is playing" (or similar phrasing) rather than
unconditionally "at startup", so replace the current sentence about triggering
random playback at startup with one that specifies it only happens when nothing
is already playing.

In `@resources/language/resource.language.zh_cn/strings.po`:
- Around line 17-18: The PO header incorrectly declares "Language: zh" and
English plural rules; update the header in resource.language.zh_cn strings.po by
replacing the "Language: zh" entry with "Language: zh_CN" and change the
"Plural-Forms: nplurals=2; plural=(n != 1)" entry to "Plural-Forms: nplurals=1;
plural=0;" so the file uses the correct Simplified Chinese locale and
single-plural rule.
🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b4ffb7e6-6f05-449c-a023-fc040d95ccbe

📥 Commits

Reviewing files that changed from the base of the PR and between eb29a19 and 2b4a510.

📒 Files selected for processing (3)
  • README.md
  • addon.xml
  • resources/language/resource.language.zh_cn/strings.po

Comment thread addon.xml Outdated
Runs as a service and will periodically update the resume point while videos are playing, so you can re-start from where you were in the event of a crash. It can also automatically resume a video if Kodi was shutdown while playing it. See setting to configure how often the resume point is set, and whether to automatically resume.
</description>
<description lang="sv_SE">
Körs som en tjänst och uppdaterar regelbundet återuppspelningspunkten vid spelning medan videor spelas upp, så att du kan starta om från där du var i händelse av ett krascher. Den kan också automatiskt återuppspela en video om Kodi stängdes av vid spelning. Se inställningarna för att konfigurera hur ofta återuppspela punkten ska ställas in och om den ska återuppspelas automatiskt.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the Swedish resume-point typo introduced in the metadata block.

Line 16 says återuppspela punkten, which reads like “replay the point” rather than “resume point” and is inconsistent with the existing Swedish PO wording.

📝 Minimal wording fix
-        Körs som en tjänst och uppdaterar regelbundet återuppspelningspunkten vid spelning medan videor spelas upp, så att du kan starta om från där du var i händelse av ett krascher. Den kan också automatiskt återuppspela en video om Kodi stängdes av vid spelning. Se inställningarna för att konfigurera hur ofta återuppspela punkten ska ställas in och om den ska återuppspelas automatiskt.
+        Körs som en tjänst och uppdaterar regelbundet återuppspelningspunkten vid spelning medan videor spelas upp, så att du kan starta om från där du var i händelse av ett krascher. Den kan också automatiskt återuppspela en video om Kodi stängdes av vid spelning. Se inställningarna för att konfigurera hur ofta återuppspelningspunkten ska ställas in och om den ska återuppspelas automatiskt.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@addon.xml` at line 16, Replace the incorrect phrase "återuppspela punkten" in
the addon metadata string with the correct Swedish term used elsewhere (e.g.
"återupptagningspunkten" or "återupptagningspunkt") so the sentence reads
consistently as "resume point"; locate the phrase in the metadata block (the
text containing "Körs som en tjänst...") and update only that token to match the
project's existing Swedish PO wording.

Comment thread README.md
Comment thread resources/language/resource.language.zh_cn/strings.po Outdated
@bossanova808
Copy link
Copy Markdown
Owner

Are you planning on attending to the CodeRabbit changes? At least for the Chinese side of things. I'm not qualified!

Or are least let me know it's wrong/ok to ignore...

@wabisabi926
Copy link
Copy Markdown
Contributor Author

wabisabi926 commented Apr 27, 2026 via email

Copy link
Copy Markdown
Contributor Author

@wabisabi926 wabisabi926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

⚠️ Branch updated during autofix.

The branch was updated while autofix was in progress. Please try again.

@bossanova808
Copy link
Copy Markdown
Owner

Thank you!

@bossanova808 bossanova808 merged commit c749e7a into bossanova808:main Apr 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants