[SNSSQS] Write-only broker option#25
Merged
Merged
Conversation
For SNSSQS implementation, current validation of options and use enforces SQS related options configuration even when you do not have any need to subscribe to the topic in a specific component/service using the broker. This is sticky, forcing you to maintain infrastructure and coupling to it in places where you don't need to. Changed a bit to make it possible to instance a write-only snssqs broker. I took the liberty of adding a new `WithCodec` option and making it mandatory. I think that it makes sense when there is that comment at the top of the constructor.
g-zubiri-tangelo
approved these changes
May 13, 2025
jbret89
approved these changes
May 13, 2025
noetangelo
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For SNSSQS implementation, current validation of options and use enforces SQS related options configuration even when you do not have any need to subscribe to the topic in a specific component/service using the broker. This is sticky, forcing you to maintain infrastructure and coupling to it in places where you don't need to.
Changed a bit to make it possible to instance a write-only snssqs broker.
I took the liberty of adding a new
WithCodecoption and making it mandatory. I think that it makes sense when there is that comment at the top of the constructor.