anchor host label validators with \Z to reject trailing newline#3743
Open
ubeddulla wants to merge 1 commit into
Open
anchor host label validators with \Z to reject trailing newline#3743ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several host and host-label validators anchor with
$, which in python also matches just before a trailing newline, so a value likeus-west-2\nslips through unchanged. that matters because these values are interpolated into the request hostname. validate_region_name gates the region taken from thex-amz-bucket-regionresponse header (or the error body) in S3RegionRedirectorv2.get_bucket_region before it is used to re-resolve the endpoint, and the same shape guards the sigv host prefix in serialize (HOST_PREFIX_RE), the hoisted host header in HeaderToHostHoister, the s3-control arn host labels in S3ControlEndpointSetter, and the ruleset host-label check in endpoint_provider. switching the end anchor to\Zrejects the trailing newline and leaves every valid label matching as before. added a regression test that feeds a trailing newline through the redirector's response-header path.