Skip to content

test: ensure cached class nodes never carry stale isExtended flag #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Jul 19, 2026
Merged

test: ensure cached class nodes never carry stale isExtended flag #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions tests/Analyser/AnalyserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,62 @@ public function testMustBeFinalRuleFlagsExtendedClassWhenChildIsOutsideScannedPa
$this->assertSame('App\BaseHandler', $violations[0]->className);
}

public function testMustBeFinalRuleReportsSameExtendedClassesOnCachedRun(): void
{
$basePath = $this->makeTempProject([
'src/BaseHandler.php' => '<?php namespace App; class BaseHandler {}',
'src/OrderHandler.php' => '<?php namespace App; final class OrderHandler extends BaseHandler {}',
'src/PaymentHandler.php' => '<?php namespace App; class PaymentHandler {}',
]);
$analysisResultCache = new AnalysisResultCache($basePath, 'cache');

$architecture = Architecture::define()
->layer('Source', 'src/')
->rule('source.must_be_final', new MustBeFinalRule('Source'));

$coldViolations = (new Analyser($basePath, $analysisResultCache, 'config'))
->analyse($architecture, [], null, AnalyserOptions::sequential())
->forRule('source.must_be_final');
$warmViolations = (new Analyser($basePath, $analysisResultCache, 'config'))
->analyse($architecture, [], null, AnalyserOptions::sequential())
->forRule('source.must_be_final');

$this->assertCount(1, $coldViolations);
$this->assertSame('App\PaymentHandler', $coldViolations[0]->className);
$this->assertCount(1, $warmViolations);
$this->assertSame('App\PaymentHandler', $warmViolations[0]->className);
}

public function testMustBeFinalRuleFlagsCachedClassOnceItsExtendingClassIsRemoved(): void
{
$basePath = $this->makeTempProject([
'src/BaseHandler.php' => '<?php namespace App; class BaseHandler {}',
'src/OrderHandler.php' => '<?php namespace App; final class OrderHandler extends BaseHandler {}',
]);
$analysisResultCache = new AnalysisResultCache($basePath, 'cache');

$architecture = Architecture::define()
->layer('Source', 'src/')
->rule('source.must_be_final', new MustBeFinalRule('Source'));

$coldViolations = (new Analyser($basePath, $analysisResultCache, 'config'))
->analyse($architecture, [], null, AnalyserOptions::sequential())
->forRule('source.must_be_final');

$this->assertCount(0, $coldViolations);

// BaseHandler.php is untouched, so its class-node cache entry stays valid;
// the extended flag must still be recomputed against the shrunken class set.
unlink($basePath . '/src/OrderHandler.php');

$warmViolations = (new Analyser($basePath, $analysisResultCache, 'config'))
->analyse($architecture, [], null, AnalyserOptions::sequential())
->forRule('source.must_be_final');

$this->assertCount(1, $warmViolations);
$this->assertSame('App\BaseHandler', $warmViolations[0]->className);
}

public function testAnalyserMarksFixableRuleViolations(): void
{
$basePath = $this->makeTempProject([
Expand Down
Loading