Skip to content

fix: report first side effect line instead of last in PSR-1 file analysis #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Jul 20, 2026
+48 −3
Merged

fix: report first side effect line instead of last in PSR-1 file analysis #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/Analyser/FileAnalysisProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,12 @@ private function fileState(array $nodes): array
if (($node instanceof Namespace_ || $node instanceof Declare_) && $node->stmts !== null) {
$state = $this->fileState($node->stmts);
$declaresSymbols = $declaresSymbols || $state['declaresSymbols'];
$hasSideEffects = $hasSideEffects || $state['hasSideEffects'];
$sideEffectLine = $state['hasSideEffects'] ? $state['sideEffectLine'] : $sideEffectLine;

if (! $hasSideEffects && $state['hasSideEffects']) {
$sideEffectLine = $state['sideEffectLine'];
}

$hasSideEffects = $hasSideEffects || $state['hasSideEffects'];

continue;
}
Expand All @@ -273,8 +277,11 @@ private function fileState(array $nodes): array
continue;
}

if (! $hasSideEffects) {
$sideEffectLine = $node->getStartLine();
}

$hasSideEffects = true;
$sideEffectLine = $node->getStartLine();
}

return [
Expand Down
38 changes: 38 additions & 0 deletions tests/Analyser/FileAnalysisProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,44 @@ final class Foo {}
$this->assertSame(4, $fileAnalysis->sideEffectLine);
}

public function testReportsFirstSideEffectLineWhenMultipleSideEffectsExist(): void
{
$file = $this->source(<<<'PHP'
<?php

final class Foo {}
echo 'first side effect';
echo 'second side effect';
echo 'third side effect';
PHP);

$fileAnalysis = (new FileAnalysisProvider())->analyse($file);

$this->assertTrue($fileAnalysis->declaresSymbols);
$this->assertTrue($fileAnalysis->hasSideEffects);
$this->assertSame(4, $fileAnalysis->sideEffectLine);
}

public function testKeepsFirstSideEffectLineAcrossNamespaceBlocks(): void
{
$file = $this->source(<<<'PHP'
<?php

namespace First {
echo 'first side effect';
}

namespace Second {
echo 'second side effect';
}
PHP);

$fileAnalysis = (new FileAnalysisProvider())->analyse($file);

$this->assertTrue($fileAnalysis->hasSideEffects);
$this->assertSame(4, $fileAnalysis->sideEffectLine);
}

public function testRejectsConditionalDeclarationsWithBranchesOrSideEffects(): void
{
$elseIfFile = $this->source(<<<'PHP'
Expand Down
Loading