Compress files on add instead of using Phar::compressFiles (fixes #80)#137
Compress files on add instead of using Phar::compressFiles (fixes #80)#137remisauvat wants to merge 1 commit intobox-project:2.0from
Conversation
|
Hoping this will get reviewed soon and merged into next release. Since I am restricted to using the Phar file release, I have had to disable compression in order to allow our project to build which has increased the resulting phar file size by 600% |
lordgnu
left a comment
There was a problem hiding this comment.
I have applied these changes and confirmed that they work as advertised. I have also confirmed that all PHP Unit tests complete successfully
|
I'm not really convinced of the results: box-project/box#29 Did I miss something? |
|
I cannot access the blackfire graphs. Can you upload a screenshot ? |
|
Damn, looks like I accidentally deleted them. I'll redo them tonight |
|
Profiles updated |
|
Still the link here box-project/box#29 (comment) give a 404 not found |
|
Should be fixed, I forgot to make them public |
Apply file compression when adding a file instead of using Phar::compressFiles at the end.
This avoid the issue of opening too many files.
On my project the build even runs faster for ~1200 files.
Tests with compressFiles:
New version with compress on the fly