constraint form clean methods validation to only forms within the project#54
Merged
boxed merged 11 commits intoboxed:masterfrom Dec 25, 2024
Merged
constraint form clean methods validation to only forms within the project#54boxed merged 11 commits intoboxed:masterfrom
boxed merged 11 commits intoboxed:masterfrom
Conversation
Owner
|
I can't accept this change due to the reformat. It's unreviewable. If you propose to reformat, you need to have a separate commit for the reformat, separate from the reformat. |
This reverts commit 4db6736.
Contributor
Author
|
okilydokily. I have undone the formatting and stuck with the basics. this has been formatted fully in another branch called blacked that I can PR if you like (really, isort and black make maintainability a lot easier by enforcing standard stylization imho). |
…ks (only applies to form checking right now)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this modification constrains the default behavior for checking Form classes' clean methods to only those forms that exist within the project. forms which would fail this test but exist in third-party libraries are ignored. I added a configuration to enable strict validation if one would desire it.
a practical use case is django-oscar, which does indeed contain a form that fails the form clean validity check, thus breaking the project through third-party code, which is something we probably want to avoid.
ps: don't hate me but I reformatted with isort and ruff/black. it seemed nice to do ;(