Remove check path#4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the check_path pre-scan filesystem check (and its aiopath dependency) from the Pyvalve clamd client, bumps the version to 0.1.5, and—at the same time—performs a substantial repository overhaul: migrating packaging from Poetry/setup.py to PEP 621 + setuptools with a uv lockfile, adding a Makefile, restructuring tests, adding a clamd-backed integration test suite, and wiring up a new GitHub Actions integration workflow.
Changes:
- Remove
check_pathcalls fromscan/contscan/multiscan/allmatchscan(and related docstring:raises PyvalveScanningError:lines), drop theaiopathimport, and bump__version__to0.1.5. - Replace Poetry config with PEP 621
pyproject.toml, adduv.lock,Makefile, mypy/pre-commit/scriv changes, and update tests (newtest_send_instream_size_limit_exceeded, fixture rework). - Add
test/test_integration_clamd.pyand.github/workflows/integration.ymlrunning clamd in Docker on every PR.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/pyvalve/__init__.py |
Removes check_path and its callers; bumps version to 0.1.5. |
pyproject.toml |
Migrates to PEP 621; adds pre-commit as runtime dep (likely incorrect) and keeps now-unused aiofile. |
uv.lock |
New lockfile generated by uv for the new packaging setup. |
Makefile |
New convenience targets wrapping uv for install/test/integration. |
mypy.ini |
Bumps python_version from 3.8 to 3.12 to match the new requires-python. |
.pre-commit-config.yaml |
Updates hook commands to use uv run --extra dev. |
test/test_pyvalve.py |
Drops check_path mocking, switches event_loop fixture to new_event_loop(), adds INSTREAM size-limit test. |
test/test_integration_clamd.py |
New live-clamd integration tests gated by PYVALVE_RUN_INTEGRATION. |
.github/workflows/integration.yml |
New workflow that boots a clamav/clamav:stable container and runs the integration tests on every PR. |
changelog.d/*.rst |
Scriv changelog fragments documenting the removal and packaging migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+17
| "aiofile>=3.8.1", | ||
| "pre-commit>=4.1.0" | ||
| ] | ||
|
|
||
| [project.optional-dependencies] | ||
| dev = [ |
| requires-python = ">=3.12,<4.0" | ||
| dependencies = [ | ||
| "asyncinit>=0.2.4", | ||
| "aiofile>=3.8.1", |
Comment on lines
+60
to
+62
| scan_result = await client.scan(str(infected_path)) | ||
| assert "FOUND" in scan_result | ||
|
|
| push: | ||
| branches: | ||
| - master | ||
| pull_request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.