Refactor MCP config generation into SDK helper#1179
Open
weinong wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR extracts MCP (Model Context Protocol) configuration helpers into a shared SDK module, re-exports them from @bradygaster/squad-sdk/config, and updates the CLI to consume the shared helpers.
Changes:
- Added
mcp-config.tsto centralize MCP server spec generation and frontmatter/config rendering helpers. - Refactored SDK
init.tsand CLIupgrade.tsto import MCP helpers from the shared module instead of duplicating logic. - Added export verification + behavior tests and bumped package versions to align CLI ↔ SDK.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/package-exports.test.ts | Adds export checks and behavior tests for MCP helper functions exposed via the config barrel. |
| packages/squad-sdk/src/config/mcp-config.ts | Introduces centralized MCP server spec + config/frontmatter helper implementations. |
| packages/squad-sdk/src/config/init.ts | Removes inlined MCP helper implementations and uses the shared mcp-config module. |
| packages/squad-sdk/src/config/index.ts | Re-exports the new MCP config module from the SDK config barrel. |
| packages/squad-sdk/package.json | Bumps SDK version to 0.9.7-preview. |
| packages/squad-cli/src/cli/core/upgrade.ts | Replaces duplicated MCP helper code with imports from @bradygaster/squad-sdk/config. |
| packages/squad-cli/package.json | Updates CLI dependency constraint to require the new SDK version. |
Comment on lines
+77
to
+95
| export function injectMcpFrontmatter(content: string, servers: McpServerSpec[]): string { | ||
| const closingStart = content.indexOf('\n---', 4); | ||
| if (!content.startsWith('---') || closingStart === -1) { | ||
| return content; | ||
| } | ||
|
|
||
| return content.slice(0, closingStart) | ||
| + '\n' | ||
| + buildMcpFrontmatterBlock(servers) | ||
| + content.slice(closingStart); | ||
| } | ||
|
|
||
| export function hasMcpFrontmatter(content: string): boolean { | ||
| const frontmatterEnd = content.indexOf('\n---', 4); | ||
| if (!content.startsWith('---') || frontmatterEnd === -1) { | ||
| return false; | ||
| } | ||
| return content.slice(0, frontmatterEnd).includes('mcp-servers:'); | ||
| } |
| expect(injected).toContain('mcp-servers:\n squad_state:'); | ||
| expect(injected).toContain('\n---\n\nBody mentions mcp-servers: only here.\n'); | ||
| }); | ||
|
|
Contributor
|
👋 Friendly nudge — this PR has had no activity for 12 days. What needs attention:
If this PR is abandoned, please close it. If it's blocked on something external, leave a comment so the team knows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bradygaster/squad-sdk/configTests
npm test -- test/package-exports.test.ts test/cli/init.test.ts test/cli/upgrade.test.tsnpm run lintFollow-up to #1166