Patch types via Patch-Type instead of Content-Type#126
Open
Patch types via Patch-Type instead of Content-Type#126
Patch-Type instead of Content-Type#126Conversation
Patch-Type instead of Content-TypePatch-Type instead of Content-Type
Member
Author
|
Note: this is a counter-proposal to #120 |
Member
Author
|
Rahul (@CxRes) pointed out a problem with my thinking here: Content-Type describes the content of the HTTP message, not the resource. Specifically: That means that if we put a patch in the But we still need a way to communicate the mime-type that the patch is applying to. So perhaps we just need two headers, like: Or a hybrid parameterized patch type, like: |
Member
Author
|
(Chair:) Since this has gotten more complicated, I don't think we can resolve it in time for draft 03, and I'm removing it from that milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec currently specifies custom patch types in the same way that the HTTP PATCH method does: using the
Content-Typeheader.But this sucks, because it clobbers other uses of Content-Type that we care about.
This rules out these use-cases:
text/markdownthat gets rendered intoapplication/html), can't specify which representation it wants its patch to apply toPatches: N, where there is not existing definition of content-type.So I propose that we ignore how PATCH does things, and introduce an actual
Patch-Typeheader for patch types. This PR makes the change. We only need to change 6 lines.(More context in https://braid.org/meeting-69/http-patch-design)