ci: expand test coverage to Ruby 3.4 and Rails 7.2, fix RSpec hash formatting#470
Merged
nashby merged 2 commits intobrainspec:masterfrom Sep 12, 2025
Merged
Conversation
- Add Ruby 3.4 to the test matrix - Add Gemfile.rails72 to test configurations
- Replace hardcoded hash strings with dynamic hash.inspect in RSpec matcher tests - Ensures test assertions work correctly with different Ruby hash formatting
Contributor
Author
nashby
approved these changes
Sep 12, 2025
Member
|
@snaka thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the CI test matrix needed to be expanded to include Ruby 3.4 and Rails 7.2 support, and there was a compatibility issue with hash output formatting across different Ruby versions that was causing RSpec test failures.
Detail
This Pull Request changes:
#inspectmethod instead of string interpolationGemfile.rails72configuration file to support Rails 7.2 stable branch testing