Auto-detect EEG cap landmarks from ChannelFile#892
Draft
tmedani wants to merge 20 commits intobrainstorm-tools:masterfrom
Draft
Auto-detect EEG cap landmarks from ChannelFile#892tmedani wants to merge 20 commits intobrainstorm-tools:masterfrom
tmedani wants to merge 20 commits intobrainstorm-tools:masterfrom
Conversation
Update GetEegCapLandmarkLabels to accept a channel file/folder and auto-compute landmark electrode names from channel locations (using in_bst_channel and Channel.Loc). The function now returns top, left, right, front, and posterior electrodes when a ChannelFile is provided, and falls back to the existing hard-coded cap name cases otherwise. (this can be removed) Update panel_digitize_2024 to call GetEegCapLandmarkLabels with the montage ChannelFile (old Name-based calls are commented out) so tooltips, montage addition, and acquisition checks use the dynamic landmark detection. Not sure if we need to update the panel_digitize
- Now allows this menu option for 3D mesh with no texture - Won't show the menu option if the `Other` type surface is `subcortical` or `isosurface`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update GetEegCapLandmarkLabels to accept a channel file/folder and auto-compute landmark electrode names from channel locations (using in_bst_channel and Channel.Loc).
The function now returns top, left, right, front, and posterior electrodes when a ChannelFile is provided, and falls back to the existing hard-coded cap name cases otherwise. (this secon part can be removed)
Update panel_digitize_2024 to call GetEegCapLandmarkLabels with the montage ChannelFile (old Name-based calls are commented out) so tooltips, montage addition, and acquisition checks use the dynamic landmark detection.
Not sure if we need to update the panel_digitize as well.
@rcassani this is related tto our discussion at the meeting.
@chinmaychinara91 you can work on top of this for the next steps