Use embedding_model parameter in AnswerRelevancy sync runner instead of model#167
Open
cgoer wants to merge 2 commits intobraintrustdata:mainfrom
Open
Use embedding_model parameter in AnswerRelevancy sync runner instead of model#167cgoer wants to merge 2 commits intobraintrustdata:mainfrom
cgoer wants to merge 2 commits intobraintrustdata:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AnswerRelevancy scorer allows to pass an
embedding_modelparameter, which is used in theEmbeddingSimilaritycall of the async runner, but not in the synchronous version, leading to wrong model usage when using the scorer synchronously.Issue #166
Edit: Moved model parameter to
EmbeddingSimilarityinit instead of eval call.