Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/src/braintrust/cli/push.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from .. import api_conn, login, org_id, proxy_conn
from ..framework2 import ProjectIdCache, global_
from ..generated_types import IfExists
from ..parameters import parameters_to_json_schema
from ..parameters import serialize_remote_eval_parameters_container
from ..util import add_azure_blob_headers


Expand Down Expand Up @@ -289,7 +289,7 @@ def _collect_evaluator_defs(
scores = [{"name": _scorer_name(scorer, i)} for i, scorer in enumerate(evaluator.scores)]
evaluator_definition: dict[str, Any] = {"scores": scores}
if evaluator.parameters is not None:
evaluator_definition["parameters"] = parameters_to_json_schema(evaluator.parameters)
evaluator_definition["parameters"] = serialize_remote_eval_parameters_container(evaluator.parameters)

functions.append(
{
Expand Down
5 changes: 4 additions & 1 deletion py/src/braintrust/cli/test_push_evaluator.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,11 @@ def test_evaluator_with_parameters(self, mock_project_ids):
_collect_evaluator_defs(mock_project_ids, functions, "bundle-1", "replace", "eval.py", evaluators)

eval_def = functions[0]["function_data"]["data"]["location"]["evaluator_definition"]
assert "parameters" in eval_def
assert "scores" in eval_def
parameters = eval_def["parameters"]
assert parameters["type"] == "braintrust.staticParameters"
assert parameters["source"] is None
assert parameters["schema"]["prompt"]["type"] == "prompt"

def test_slug_from_source_file(self, mock_project_ids):
evaluators = {"Test Eval": _make_evaluator("test-project", ["accuracy"])}
Expand Down
Loading