Extract Dataset and use api instead of state#98
Merged
Conversation
realark
approved these changes
Feb 4, 2026
Contributor
|
I'm not sure about this one. Will comment tmw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests makes two refactors to Evals and Datasets.
Issue: Dataset is internal to
EvalRight now, datasets are entirely internal to Eval and inaccessible for other purposes.
Idea: Extract it to a first-class API
Issue: Use of
stateforEval.runRight now, Eval uses
stateas an argument to run:This seems undesirable, given that
Stateis meant to be an internal construct, rather than a public one... if we make changes to state management, it could cause a breaking change.Idea: Encapsulate within
apiRather than expose
state:as an argument, exposeapi:instead. This simplifies the logic, and substitutes an internal construct for a more meaningfully public one.