chore: remove smoke test#74
Closed
Cedric / ViaDézo1er (viadezo1er) wants to merge 2 commits into
Closed
Conversation
Member
|
Yeah it was intentional to check whether the agent will actually do something when invoked. It is also intentional that we do not use different settings than with the normal run, because we want to see in a relatively quick and reliable way whether the agent would work. I updated the pr to use cheaper models and lower reasoning so that the check is faster. I'll leave it up to you tho whether you want to merge with this newfound information I just gave you. |
Luca Forstner (lforst)
approved these changes
Jun 5, 2026
Collaborator
Author
|
Let's not change anything then, this steps takes ~7s that's fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove smoke test doing an almost empty call to claude/codex save a few seconds in
where the user can only wait.
I'm wondering, the code is a bit too polished but at the same time a bit too sloppy.
Is there a reason to add a smoke test or was it slop Luca Forstner (@lforst)?
If we keep them, I'll set codex effort to low instead of xhigh.