Add memoization option to avoid unnecessary requests#173
Open
SchneiderOr wants to merge 4 commits intobramus:masterfrom
Open
Add memoization option to avoid unnecessary requests#173SchneiderOr wants to merge 4 commits intobramus:masterfrom
SchneiderOr wants to merge 4 commits intobramus:masterfrom
Conversation
added 4 commits
July 15, 2021 18:04
|
@bramus any news for this PR? Looks like something really useful to preserve quota when origin and destination do not change between renders. |
Author
|
Im working with this code on my project for few months now and it works very well, Im waiting on project maintainer to decide if he want to merge it down or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
I've added another prop that the component can take called isMemoized, by default requests are not memoized, but if you pass either boolean or a callback function you can decide when you want to memoize the request, if you pass only true to the isMemoized, memoization will be by the callee arguments (origin, destination, region, etc)
This memoize reduce a lot of unnecessary requests and preserve quota
Also in this PR - format the files with formatter rather then keeping them in an inconsistent styling