Open
Conversation
…rt type and colour accordingly. Added the individual direction steps to the return type in order to break down the journey in to multiple steps.
Owner
|
Thanks for this PR. It's a nice addition. A few questions though:
Please keep the contents of your PR limited to only the changes that it says it provides. |
Author
|
@bramus Looks like I had some rouge VSCode extension removing unused props! Resolved both issues. |
Owner
|
@garydevenay Thanks for the extra pushed commits. It still looks a bit borked though, when you check the "files changed" tab. Please go over your changes again. Don't be afraid to squash a few commits too, to keep the history clean. Thanks. |
|
Any updates on this? |
|
this is such a useful feature. any update? |
bump, any updates this would be awesome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a transit polyline, I added a prop to allow the line to be split and automatically coloured by the transit line type provided by Google.
I also added the journey steps to the onReady return object to facilitate the breakdown of a journey into multiple steps over many transit types.