Add Home Assistant app repository and app#13
Conversation
ss89
force-pushed
the
home-assistant-app
branch
from
498d9c0 to
776bff2
Compare
|
accidentally left a reference to my fork inside and removed that |
ss89
force-pushed
the
home-assistant-app
branch
from
776bff2 to
2613398
Compare
|
one more readme adjustment to make it easier to setup for first-time home assistant app (from third party sources) users. |
brandon1024
left a comment
brandon1024
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I'll have to spend a bit more time looking through these changes and familiarizing myself with this integration mechanism with HA. I can't guarantee I'll get to it this week but I'll try.
For now, I think we should skip the logo.
| version: "1.0.0" | ||
| slug: openevt | ||
| description: >- | ||
| OpenEVT integration daemon. Connects to an OpenEVT inverter and exposes |
There was a problem hiding this comment.
This shouldn't be OpenEVT inverter -- should be Envertec inverter instead.
There was a problem hiding this comment.
True, i will adjust the description to be more precise (and correct)
| configuration: | ||
| address: | ||
| name: Inverter address | ||
| description: Scheme + IP or hostname + port of the inverter |
There was a problem hiding this comment.
This wording is a bit confusing -- perhaps this would be better:
Address and port of the microinverter (e.g. 192.0.2.1:14889).
OpenEVT doesn't support difficult schemes, just IP:PORT.
There was a problem hiding this comment.
Indeed, i got confused between the home assistant configuration.yaml setup (using the scheme), while the app itself only requires the ip+port in the inverter address. Will adjust it.
| description: Scheme + IP or hostname + port of the inverter | ||
| serial_number: | ||
| name: Inverter serial number | ||
| description: Serial number of the inverter to track data for |
There was a problem hiding this comment.
Maybe a bit clearer:
Serial number of the microinverter (e.g. 31583078).
| arch: | ||
| - amd64 | ||
| - aarch64 | ||
| host_network: true |
There was a problem hiding this comment.
This concerns me a little. Assuming this refers to host networking, this can be problematic in in security sensitive environments, and I wouldn't want to expose OpenEVT to networking on the host. For example, this would permit OpenEVT to access other services bound to the loopback interface on the host, which I wouldn't permit in my environment.
What's the rationale for this?
There was a problem hiding this comment.
Assuming this refers to host networking, this can be problematic in in security sensitive environments
You are assuming right and for good reason. I wasn't paying enough attention during my testing and actually wanted to use the port forwarding feature instead. Forgot to get rid of the host networking. I will adjust it and test with just port forwarding.
| @@ -0,0 +1,12 @@ | |||
| # OpenEVT | |||
|
|
|||
| This app scrapes data from Evertech inverters and provides them scrapable for home assistant users (and as prometheus metrics as well). | |||
There was a problem hiding this comment.
In fact they call themselves Envertech (see: https://www.envertec.com/). While the domain name seems to implicate that it should be Envertec, when browsing the page in all occurrences i found it is Envertech. Even in the about us page here: https://www.envertec.com/about-us/
EDIT: However i will fix my originally flawed spelling (Evertech)
There was a problem hiding this comment.
I stand corrected! What a strange company.. 😅
|
|
||
| Set the following options in the UI when installing the app: | ||
|
|
||
| - address: Address including port for the OpenEVT inverter |
There was a problem hiding this comment.
- OpenEVT inverter
+ Envertec inverter
|
I will try to tackle your comments today evening. Thanks for taking a look. 👍🏻 |
ss89
force-pushed
the
home-assistant-app
branch
from
919fad5 to
e06600f
Compare
|
I did now also remove the ingress part as it wasn't really working (somehow when setting the path the webbrowser would use home assistants ui port (not the ingress one) and but use the path specified from the config. |
ss89
force-pushed
the
home-assistant-app
branch
from
46c1b68 to
33108fe
Compare
2 participants
closes #12
Let me know what you think.
The logo/icon is made with
x/flux2-kleinin ollama. Let me know if you'd rather not add a logo or if you want to replace it with something you had in mind already.Only thing not working for me right now is the ingress part from the addon/app page.
Can you also test it with your home assistant?
As mentioned in the issue already (edited the message earlier today), i don't have an inverter at hand to test that it really works.