Add scroll marker using fake scrollbar implementation#436
Add scroll marker using fake scrollbar implementation#436arogl wants to merge 8 commits intobrandon1024:developfrom
Conversation
|
interesting! do you have screenshots? |
|
Options screen No Matches Matches on news.com.au 
It has light and dark scrollbar capability, but not extensively tested |
follow existing style.
Less noise.
- Can put "enable" or "disable" in description instead of messages. - Can omit "_enabled" from js code to shorten code lines.
pzhlkj6612
left a comment
pzhlkj6612
left a comment
There was a problem hiding this comment.
The code and L10N strings in this PR don't seem to be consistent with the existing style and design, and there are some useless if-else and try-catch statements.
I've modified your changes in arogl#1. PLease check. The code in "content/highlighter.js" needs more cleanup and I'm working on it.
You can directly merge that PR if it looks good to you. The merge commit can be preserved, and you don't need to force-push. The maintainer will squash all commits during PR merging.
I believe that keeping things consistent will help future developers. I also believe that we will compose some linter rules for this project then.
2 participants
Fixes
#368
Changes Proposed in this Pull Request:
Additional Comments and Documentation:
Produced with the help of claude