Skip to content

Few suggestion on the implementation#1

Open
omarqx wants to merge 3 commits intobrandonjang90:mainfrom
omarqx:review
Open

Few suggestion on the implementation#1
omarqx wants to merge 3 commits intobrandonjang90:mainfrom
omarqx:review

Conversation

@omarqx
Copy link

@omarqx omarqx commented Nov 17, 2023

Summery

Overall the code is pretty good, with few comments

Comments

  • Make sure that the implementation works, when I ran the code it didn't work.
  • Try to write task based commits into the code.
  • Make sure to write the code into a pull request such as this.
  • Some none coding specific practices such as indentation, comments, and naming conventions helps make the code more readable and easier to maintain.

@omarqx omarqx changed the title Review Few suggestion on the implementation Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant