feat: detect wildcard allowedTools as unrestricted#1
Merged
brandonwise merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wildcard tool allowlists (
allowedTools: ["*"],all,any) were being treated as safe restrictions.This PR makes wildcard allowlists fail closed across scan + inspect so broad tool exposure is surfaced instead of silently passing.
Why now
Recent demand signals keep converging on the same failure mode: agentic permissions without real guardrails.
What changed
allowedToolsas:*,all,any, etc.)inspectoutput:allowlist_present=falsewhen wildcard allowlists are usedwildcard_allowlistrisk tagValidation (deep)
1) Full test suite (repo-level)
cargo test --quiet -- --test-threads=1✅ PASS (202 unit tests + 34 integration tests)
2) Targeted tests for changed modules
cargo test wildcard_allowlist --quiet✅ PASS (5 targeted tests)
3) Lint/type/build checks
cargo clippy --all-targets -- -D warnings✅ PASS
cargo build --release✅ PASS
4) Smoke/integration behavior check
Command run:
✅ PASS
AW-007 findings: 1Top title: Wildcard tool allowlist on high-risk serverRisk / rollout
Low-risk, scoped rule-hardening change. No unrelated refactors.