Skip to content

Add support for NixOS#69

Open
wstein wants to merge 2 commits intobrave:mainfrom
wstein:main
Open

Add support for NixOS#69
wstein wants to merge 2 commits intobrave:mainfrom
wstein:main

Conversation

@wstein
Copy link

@wstein wstein commented Jul 6, 2025

Resolves #13

  • add section to detect and use nix-env package manager
  • update error message: "Could not find a supported..."

- add section to detect and use nix-env package manager
- update error message: "Could not find a supported..."
@wstein wstein requested review from fmarier and wknapik as code owners July 6, 2025 12:07
@wstein wstein changed the title Add support for NixOS (#13) Add support for NixOS Jul 6, 2025
Comment on lines +98 to +99
# IMPORTANT: Always check nix-env last. It is the default on NixOS, but on other systems it may be installed as a cross-platform package manager.
# Prioritize native package managers first to ensure proper system integration and avoid overriding system management.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the comment, but the question about whether this is the best way to install remains. Are there other competing options to consider, or is this it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The arguments for the configuration.nix route highlighted by Ask Brave seem pretty compelling.

On the other hand, do we know how many changes have been made to that file since the last nixos-rebuild? It could be more risky/invasive to run from install.sh than the installation commands for other package managers. We also opted for the least invasive actions possible with rpm-ostree for similar reasons - we don't want to potentially break a system, or enable changes the user wasn't ready/intending to enable yet.

And then we also have the case of nixOS vs nix on another distro. Which might call for different approaches. Would this PR represent what the user would want in the "other distro" case?

It would be great to get some input from day-to-day nix(OS) users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for NixOS

2 participants