Skip to content

Comments

WIP: VEO video generation snackbars and editor info messages logic#7111

Closed
ggenovgoogle wants to merge 7 commits intobreadboard-ai:mainfrom
ggenovgoogle:main
Closed

WIP: VEO video generation snackbars and editor info messages logic#7111
ggenovgoogle wants to merge 7 commits intobreadboard-ai:mainfrom
ggenovgoogle:main

Conversation

@ggenovgoogle
Copy link
Contributor

@ggenovgoogle ggenovgoogle commented Nov 24, 2025

  • New custom event for showing the snackbar inside the runtime / visual editor from the video generation file
  • Fixed css stylings inside the snackbar when action button is too long
  • Added a new property for action button: cssClass
  • Added a logic for detecting and showing specific snackbar messages based on the user domain and if he is out of credits
  • Added logic for different editor info for VEO generation
image image image image image

@ggenovgoogle ggenovgoogle marked this pull request as draft November 24, 2025 13:30
@ggenovgoogle ggenovgoogle marked this pull request as ready for review November 24, 2025 14:03
@ggenovgoogle ggenovgoogle changed the title Snackbar limitation messages for VEO generation if google user or not VEO video generation snackbars and editor info messages logic Nov 24, 2025
@ggenovgoogle ggenovgoogle marked this pull request as draft November 25, 2025 08:55
@ggenovgoogle ggenovgoogle marked this pull request as ready for review November 25, 2025 12:05
Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong approach. Here's how I would do it:

  1. create another property on the Mode type in packages/a2/src/generate/main.ts that's named something like subscriberInfo and populate it in MODES array with the right message

  2. when displaying the message in the step editor, check to see if the user is a subscriber (using UIState object) and display either info or subscriberInfo.

The snack bar bits should be a separate PR, as it is more involved.

Outcome,
StoredDataCapabilityPart,
} from "@breadboard-ai/types";
import * as BreadboardUiTypes from "@breadboard-ai/shared-ui/types";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a circular reference. shared-ui depends on a2 and now a2 depends on shared ui

@ggenovgoogle
Copy link
Contributor Author

This is the wrong approach. Here's how I would do it:

  1. create another property on the Mode type in packages/a2/src/generate/main.ts that's named something like subscriberInfo and populate it in MODES array with the right message
  2. when displaying the message in the step editor, check to see if the user is a subscriber (using UIState object) and display either info or subscriberInfo.

The snack bar bits should be a separate PR, as it is more involved.

Hey @dglazkov , thanks for the feedback! It seems there were things added in the past days which were not present at the moment i was creating the pull request. For example the UIState credits counter. I will fix the stuff and create 2 separate PR's as you suggested. 1 for the subscriberInfo message and 1 for the snackbars. Do you have any comments on the snackbar messages / events, is that okay?

@ggenovgoogle ggenovgoogle changed the title VEO video generation snackbars and editor info messages logic WIP: VEO video generation snackbars and editor info messages logic Dec 1, 2025
@ggenovgoogle
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants