Merged
Conversation
## What Fixes several port faithfulness issues found during a side-by-side audit of all six agent functions. ## Why Aligns the Python ports with the tuned TS behavior. ## Changes ### `opal-backend-shared` - **`functions/generate.py`** — Fixed `generate_text` to forward thought parts to status callback instead of skipping them. - **`functions/image.py`** — removed invented `_INSTRUCTION` text (TS has none) - **`functions/video.py`** — removed invented `_INSTRUCTION` text - **`functions/audio.py`** — removed invented `_INSTRUCTION` text - **New** `tests/test_code_gen.py` — 16 tests - Updated `tests/test_generate.py`, `test_image.py`, `test_video.py`, `test_audio.py` ### `PROJECT_CORNERSTONE.md` - Added roadmap items to 4.9: status metadata plumbing, `url_context` consent flow, function group consolidation ## Testing ```bash cd packages/opal-backend-shared && source .venv/bin/activate python -m pytest tests/test_generate.py tests/test_code_gen.py tests/test_image.py tests/test_video.py tests/test_audio.py -v ``` All 95 tests pass.
📊 Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes several port faithfulness
issues found during a side-by-side audit of all six agent functions.
Why
Aligns the Python ports with the
tuned TS behavior.
Changes
opal-backend-sharedfunctions/generate.py— Fixedgenerate_textto forward thought parts to status callbackinstead of skipping them.
functions/image.py— removed invented_INSTRUCTIONtext (TS has none)functions/video.py— removed invented_INSTRUCTIONtextfunctions/audio.py— removed invented_INSTRUCTIONtexttests/test_code_gen.py— 16 teststests/test_generate.py,test_image.py,test_video.py,test_audio.pyPROJECT_CORNERSTONE.mdurl_contextconsentflow, function group consolidation
Testing
All 95 tests pass.