Added children prop to make typescript happy#22
Open
DroidZed wants to merge 1 commit intobreeffy:masterfrom
Open
Added children prop to make typescript happy#22DroidZed wants to merge 1 commit intobreeffy:masterfrom
DroidZed wants to merge 1 commit intobreeffy:masterfrom
Conversation
Author
|
Any news regarding this PR getting merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I installed the package the typescript linter was spawning errors about the
Menucomponent not accepting children.When looked into the code, I noticed that the
childrenprop was not found nor thePropsinterface was extending from theViewPropinterface to implicitly pass in the styles, testID, and children props.A small fix was to have the
childrenprop added to not clutter the auto completion for the component in the editor.Also, the docs were mentioning the
childrenprop being present while it's not. Please fix this asap.Thank you.