Add support for the "support_tags" command when running with no hooks…#140
Add support for the "support_tags" command when running with no hooks…#140lambdaknight wants to merge 2 commits intobreser:masterfrom
Conversation
… or in "no daemon" mode.
|
Awesome! Can you add some tests for these changes? |
|
I added a test. Sorry this took so long. I don't have much time to work on this. As a disclaimer, I want to say that I don't program in JS much, so apologies if this code is just absolutely terrible. |
|
Can you rebase this so that it picks up the fixes to the broken test suite? |
|
Could you please give some information when this fix will be merged to the master branch? Thank you @breser |
|
@khdevel Was hoping @lambdaknight would rebase this so that I could see that the tests properly pass since the test suite was broken when he did this. Hasn't happened yet so I need to find some time to do it myself. |
|
Great @breser ! I extremely need such change for my super-mega deployment process :) I am looking forward for it! |
|
...any news about the release day? |
4 participants
… or in "no daemon" mode.
I added a issue (#139) about "support_tags" not working in "no daemon" mode. I made a small change that gets it working. Not sure it is the optimal way to do it, but I leave it here for your perusal.