Remove deprecated and redundant CLI commands#244
Open
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
Open
Remove deprecated and redundant CLI commands#244devin-ai-integration[bot] wants to merge 7 commits intomainfrom
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
Conversation
- Remove deprecated runtasks command (replaced by configure) - Remove redundant recreate command (equivalent to delete + start) - Remove dev-only commands: test, clipboard, envvars, connect, fu - Remove poorly documented commands: writeconnectionevent, updatemodel - Remove user-specified commands: configure-env-vars, import-ide-config, secret - Remove hello onboarding command and references - Fix duplicate start command registration This cleanup improves CLI organization and removes unused/experimental functionality. All core commands (start, stop, delete, reset, login, logout, ls, shell, open) remain intact. Co-Authored-By: Alec Fong <alecsanf@usc.edu>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The funlen nolint directive is no longer needed after removing deprecated commands from createCmdTree function. Also fix gofumpt formatting in notebook.go. Co-Authored-By: Alec Fong <alecsanf@usc.edu>
- Remove ollama import and registration from cmd.go - Delete pkg/cmd/ollama directory and all related files - Ollama command was identified as an additional removal request This completes the CLI command cleanup by removing the AI/ML model server functionality from the core CLI. Co-Authored-By: Alec Fong <alecsanf@usc.edu>
- Remove status import and registration from cmd.go - Delete pkg/cmd/status directory and all related files - Status command was identified as an additional removal request This further streamlines the CLI by removing the instance status functionality that was redundant with other status checking methods. Co-Authored-By: Alec Fong <alecsanf@usc.edu>
- Remove healthcheck import and registration from cmd.go - Delete pkg/cmd/healthcheck directory and all related files - Healthcheck command was identified as an additional removal request This further streamlines the CLI by removing the backend health checking functionality from the core CLI commands. Co-Authored-By: Alec Fong <alecsanf@usc.edu>
…istency - Update help text in create, start, stop, portforward, notebook, and scale commands - Preserve 'local machine' and 'host machine' references as they refer to user's computer - Addresses GitHub comment requesting terminology consistency Co-Authored-By: Alec Fong <alecsanf@usc.edu>
| ) | ||
|
|
||
| var ( | ||
| createLong = "Create a new Brev machine" |
Collaborator
There was a problem hiding this comment.
Appreciate the standardization of language.
Minor follow up:
- Customer & internal documentation for product terminology
PreciselyAlyss
previously approved these changes
Jul 22, 2025
Collaborator
PreciselyAlyss
left a comment
There was a problem hiding this comment.
- Draft pull request for updating GL-hosted Brev docs for CLI changes
- Get a review from someone that actual writes Go
pkg/cmd/notebook/notebook.go
Outdated
| fmt.Print("\n" + warningType(" Please keep this terminal open 🤙 ")) | ||
|
|
||
| hello.TypeItToMeUnskippable27("\nClick here to go to your Jupyter notebook:\n\t 👉" + urlType("http://localhost:8888") + "👈\n\n\n") | ||
| fmt.Print("\nClick here to go to your Jupyter notebook:\n\t 👉" + urlType("http://localhost:8888") + "👈\n\n\n") |
Collaborator
There was a problem hiding this comment.
$0.02: We can drop the "here" part of click here. People know they can click the url.
Suggested change
| fmt.Print("\nClick here to go to your Jupyter notebook:\n\t 👉" + urlType("http://localhost:8888") + "👈\n\n\n") | |
| fmt.Print("\nClick to go to your Jupyter notebook:\n\t 👉" + urlType("http://localhost:8888") + "👈\n\n\n") |
- Change 'Click here to go to your Jupyter notebook' to 'Click to go to your Jupyter notebook' - Addresses GitHub comment suggestion from PreciselyAlyss for cleaner UX text Co-Authored-By: Alec Fong <alecsanf@usc.edu>
Contributor
Author
|
❌ Cannot revive Devin session - the session is too old. Please start a new session instead. |
Contributor
|
I merged improvements to the --help page that also removed broken commands. I think we can close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated and redundant CLI commands
Summary
This PR removes 13 CLI commands that were identified as deprecated, redundant, poorly documented, or experimental. The cleanup removes ~4,900 lines of code while preserving all core CLI functionality.
Commands removed:
runtasks- deprecated in favor ofconfigurerecreate- redundant withdelete+startsequencehello- onboarding command with references across multiple commandsbackground- niche use case with limited documentationtest,clipboard,envvars,connect,fu- dev-only commands behind feature flagswriteconnectionevent,updatemodel- poorly documented internal commandsconfigure-env-vars,import-ide-config,secret- user-specified removalsstartcommand registrationCore commands preserved:
start,stop,delete,reset,login,logout,ls,shell,open,create,org,set, etc.Review & Testing Checklist for Human
hellocommand and onboarding logic was completely removed from login, ls, shell, and open commands. Ensure new users can still successfully get startedDiagram
%%{ init : { "theme" : "default" }}%% graph TD cmd["pkg/cmd/cmd.go<br/>Command Registration"]:::major-edit login["pkg/cmd/login/login.go<br/>Login Command"]:::minor-edit shell["pkg/cmd/shell/shell.go<br/>Shell Command"]:::minor-edit ollama["pkg/cmd/ollama/ollama.go<br/>Ollama Command"]:::minor-edit notebook["pkg/cmd/notebook/notebook.go<br/>Notebook Command"]:::minor-edit open["pkg/cmd/open/open.go<br/>Open Command"]:::minor-edit ls["pkg/cmd/ls/ls.go<br/>List Command"]:::minor-edit hello["pkg/cmd/hello/<br/>(DELETED)"]:::deleted runtasks["pkg/cmd/runtasks/<br/>(DELETED)"]:::deleted recreate["pkg/cmd/recreate/<br/>(DELETED)"]:::deleted others["11 other command dirs<br/>(DELETED)"]:::deleted cmd --> login cmd --> shell cmd --> ollama cmd --> notebook cmd --> open cmd --> ls cmd -.-> hello cmd -.-> runtasks cmd -.-> recreate cmd -.-> others hello -.-> login hello -.-> shell hello -.-> open hello -.-> ls subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Deleted]:::deleted end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef deleted fill:#FFB6C1Notes
TypeItToMeUnskippable27calls with simple terminal prints - behavior may differ slightly