feat(validation): add firewall validation for iptables/ufw rules#81
Merged
feat(validation): add firewall validation for iptables/ufw rules#81
Conversation
82c3e37 to
0f596bf
Compare
aa737f6 to
f592a04
Compare
- Add networking_validation.go with ValidateFirewallBlocksPort and ValidateDockerFirewallBlocksPort to verify servers on 0.0.0.0 are not accessible from outside - Extract instance validation functions to instance_validation.go - Add RunFirewallValidation to validation suite - Integrate ValidateFirewallBlocksPort into RunInstanceLifecycleValidation
ca7bb68 to
37e47b1
Compare
Contributor
|
Rebasing on main to ensure nebius tests now pass |
drewmalin
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networking_validation.gowithValidateFirewallBlocksPortandValidateDockerFirewallBlocksPortto verify servers on 0.0.0.0 are not accessible from outsideinstance_validation.gofor better organizationRunFirewallValidationstandalone suite for comprehensive firewall testingValidateFirewallBlocksPortandValidateDockerFirewallBlocksPortintoRunInstanceLifecycleValidationThis validates that the iptables rules from BREV-2599 are working correctly by verifying that Docker containers binding to 0.0.0.0 on non-allowed ports cannot be reached from outside.
Validation Proof
Tested via PR #82 which flushed the DOCKER-USER iptables chain to simulate the vulnerable state:
Without iptables rules (vulnerable):
Result:
port 9999 is accessible from outside but should be blocked by firewall (attempt 1 succeeded)❌ FAILWith iptables rules (secure):
Result:
checkPortBlocked: confirmed port 9999 is blocked after 3 attempts✅ PASSTest plan