Fix Mission dialog title reset and add unsaved-changes warning#181
Open
Knobee wants to merge 1 commit intobrian7704:masterfrom
Open
Fix Mission dialog title reset and add unsaved-changes warning#181Knobee wants to merge 1 commit intobrian7704:masterfrom
Knobee wants to merge 1 commit intobrian7704:masterfrom
Conversation
Addresses issues 1 and 2 of brian7704#180. - New Mission button now resets the dialog title back to "Add Mission" after the user has previously opened the Edit dialog. - Modal close (outside-click / ESC / x button) now opens a confirmation prompt when the form has unsaved changes, instead of discarding them silently. Issue 3 (password removal) needs a backend change in brian7704/OpenTAKServer mission_api.py and is out of scope for this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
|
Thanks for this PR. I tested it but the new "are you sure" modal renders behind the already opened add/edit mission modal making it unclickable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue 3 — out of scope
Issue 3 (no UI to remove an existing mission password) needs a backend change before it can be done cleanly:
DELETE /Marti/api/missions/<name>/passwordendpoint cited in the issue requires a Data Sync token / iTAK certificate and is not callable from the admin web UI./api/missionsPOST handler ignorespassword: ""on create (mission_api.py:103).password=""but does not recomputepassword_protected, leaving stale state.This needs a separate UI + backend PR.
Test plan
🤖 Generated with Claude Code