Match quoted glob chars literally in [[ == ]] patterns (batch87) - #292
Merged
Conversation
The right-hand side of [[ word == pattern ]] (and !=) is a pattern in which a quoted or backslash-escaped glob metacharacter matches literally, but CondEval expanded it with expand_no_split (quote removal), so `[[ abc == a\* ]]' and `[[ ab == a"*" ]]' wrongly matched as active globs. Expand the ==/!= right-hand side with expand_pattern instead, which backslash- escapes quoted glob characters while leaving unquoted ones active -- the same expansion the case statement already uses. Closes #291.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The right-hand side of
[[ word == pattern ]](and!=) is a pattern in which a quoted or backslash-escaped glob metacharacter matches literally, butCondEvalexpanded it withexpand_no_split(quote removal), so the protecting quotes were stripped beforestrmatch:Fix: expand the
==/!=right-hand side withexpand_pattern(which backslash-escapes quoted glob chars while leaving unquoted ones active) — the same expansion thecasestatement already uses. Active (unquoted) globs still match.Testing
cond79 → 75,comsub237 → 35 (bonus), zero regressions*/?),==/!=, and literal cases against bash 5.3Closes #291.