Make the personality builtin available in csh/tcsh mode - #310
Merged
Conversation
The csh/tcsh interpreter keeps its own builtin table, which omitted the `personality' pseudo-builtin, so a session in the csh or tcsh persona reported `personality: Command not found' and could neither query its current mode nor switch back out. Recognize `personality' as a csh builtin and route it through the shared run_builtin dispatcher, which handles the pseudo-builtin in every persona. Closes #309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309.
The csh/tcsh interpreter (
run_csh) maintains its own builtin table, which did not include thepersonalitypseudo-builtin. A session in the csh or tcsh persona therefore gotpersonality: Command not foundand had no way to query its current mode or switch back out:personalityis now recognized as a csh builtin and routed through the sharedrun_builtindispatcher (which already handles the pseudo-builtin in every persona).personality tcsh -c "personality"printstcsh, an unknown mode reportspersonality: unknown personality: Xinstead of "Command not found", and switching back to bash works.ctest22/22,run_diffall 234 scripts match bash. No regressions.