Hide proxy device when target output device is unavailable#61
Open
seungwoochoe wants to merge 1 commit intobriankendall:masterfrom
Open
Hide proxy device when target output device is unavailable#61seungwoochoe wants to merge 1 commit intobriankendall:masterfrom
seungwoochoe wants to merge 1 commit intobriankendall:masterfrom
Conversation
|
This looks like a useful but simple improvement. @briankendall any chance we can consider this? |
Owner
|
Sorry for letting this one slide for a while without responding. This is a good idea, but needs a setting, one that defaults to this feature being off so as not to change the behavior for existing users. One of the major use cases for the proxy device is having a device that doesn't disappear but can still be used to consistently play to the right device, for apps that don't properly handle changes to available audio devices. |
|
Very reasonable! Thank you for the response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements automatic device hiding/showing based on target output availability.
When the proxied audio device is disconnected, the proxy audio device automatically hides itself from the system audio device list. When the target device reconnects, the proxy device reappears. This allows macOS's built-in audio routing logic to take over and automatically switch to the appropriate fallback device like built-in speakers.