Correct type hinting for @return true -> @return bool#28
Open
craigblubolt wants to merge 1 commit intobrickfox:devfrom
Open
Correct type hinting for @return true -> @return bool#28craigblubolt wants to merge 1 commit intobrickfox:devfrom
craigblubolt wants to merge 1 commit intobrickfox:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the return type hinting for booleans, such that we now hint as
bool, instead oftrue. Performed with a find & replace across the repository.This enables higher levels of
phpstanchecking (on dependent code), removing errors such as "Negated boolean expression is always false".