fix: preserve augmented request json args#687
Merged
brickfrog merged 1 commit intoJul 9, 2026
Conversation
Owner
Author
|
Choir: GitHub Actions rollup reports all checks successful on the latest head — re-check review/merge policy on GitHub (not an approval or merge signal by itself). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves native JSON args in format_augmented_request by copying the FieldMap through each_json and using RequestArgs::from_values for the augmented request. Adds transport regressions for array, object, and string arg round-trips.\n\nVerification: moon test --target native && moon run src/bin/choir_lint --target native passed (2266/2266 tests).
Verification
Generated by Choir from commands executed in the leaf workspace.
moon test --target nativemoon run src/bin/choir_lint --target native