fix: discover() ergonomics, dataFormat/env aliases, and Transport lis…#27
Merged
Conversation
…tener leak discover(): - DiscoverResult.data is now always an array (empty on failure) and gains a .results alias plus Symbol.iterator, so documented usage never throws. - Failed discover() surfaces server-provided error/message detail in the thrown APIError instead of a bare status. DX: - dataFormat accepts 'md' as an alias for 'markdown'. - BRIGHTDATA_API_KEY accepted as a fallback env var after BRIGHTDATA_API_TOKEN. Transport: - Replace the per-instance beforeExit listener with a single shared listener tracked by an open-transport counter, fixing MaxListenersExceededWarning when many clients are created. Warning message is now count-aware. README updated for all of the above. New unit tests cover each change (309 unit tests green; lint, typecheck, and build clean). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tener leak
discover():
DX:
Transport:
README updated for all of the above. New unit tests cover each change (309 unit tests green; lint, typecheck, and build clean).