Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 15 15
Lines 349 349
Branches 50 50
=======================================
Hits 285 285
Misses 64 64Continue to review full report at Codecov.
|
Owner
|
I think you should update the PR to revert the previous one without this css change. Since updating css solves your problem, you can apply this directly in your project stylesheet and do nothing in medium-draft itself as no one else has raised this particular issue. |
75ff4d3 to
62c4c09
Compare
Contributor
Author
|
Alright, done. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really sorry, I didn't properly test the previous implementation after using the hasFocus boolean directly. Turns out this prevents the toolbar from opening at all.
I've reverted the commits and implemented a css-based solution. This will not work in all browsers though.
Sorry for the trouble!