Fix bug when pre-reading /dev/stdin to get type#7049
Merged
Conversation
mattnibs
commented
Jun 15, 2026
Comment on lines
-77
to
-79
| if closer, ok := s.r.(io.Closer); ok { | ||
| return closer.Close() | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This was pre-emptively closing the fjson io.Reader which was causing error when we tried to seek to the beginning after gathering type info.
mattnibs
force-pushed
the
file-type-reset
branch
5 times, most recently
from
926dd55 to
b86a721
Compare
nwt
approved these changes
Jun 16, 2026
On BSD/macOS, open("/dev/stdin") dups fd 0 rather than re-opening the
file, so it shares stdin's file offset. Reset to 0 so a re-open reads
from the start instead of resuming where the last read left off.
mattnibs
force-pushed
the
file-type-reset
branch
from
b86a721 to
b6642af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On BSD/macOS, open("/dev/stdin") dups fd 0 rather than re-opening the file, so it shares stdin's file offset. Reset to 0 so a re-open reads from the start instead of resuming where the last read left off.