Skip to content

simplify super.Value.DerefByColumn #7056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
Jun 18, 2026
+10 −25
Merged

simplify super.Value.DerefByColumn #7056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 10 additions & 25 deletions value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,38 +307,23 @@ func (r Value) Walk(rv Visitor) error {
return Walk(r.Type(), r.Bytes(), rv)
}

func (r Value) nth(n int) (scode.Bytes, bool) {
if typ := TypeRecordOf(r.typ); typ != nil {
var elem scode.Bytes
for i, it := 0, r.Bytes().Iter(); i <= n; i++ {
if it.Done() {
return nil, false
}
elem = it.Next()
}
return elem, true
}
var zv scode.Bytes
for i, it := 0, r.Bytes().Iter(); i <= n; i++ {
if it.Done() {
return nil, false
}
zv = it.Next()
}
return zv, true
}

func (r Value) Fields() []Field {
return TypeRecordOf(r.Type()).Fields
}

func (v *Value) DerefByColumn(col int) *Value {
if v != nil {
if bytes, ok := v.nth(col); ok {
return NewValue(v.Fields()[col].Type, bytes).Ptr()
if v == nil {
return nil
}
it := v.Bytes().Iter()
var b scode.Bytes
for range col + 1 {
if it.Done() {
return nil
}
b = it.Next()
}
return nil
return NewValue(v.Fields()[col].Type, b).Ptr()
}

func (v Value) IndexOfField(field string) (int, bool) {
Expand Down
Loading