Skip to content

Add optional forward_command_on_receive to module manager interface#23

Open
danprudky wants to merge 1 commit into
mainfrom
BAF-1204/Teleoperation-Control
Open

Add optional forward_command_on_receive to module manager interface#23
danprudky wants to merge 1 commit into
mainfrom
BAF-1204/Teleoperation-Control

Conversation

@danprudky
Copy link
Copy Markdown

Adds forward_command_on_receive(unsigned int device_type) as an optional export to the module manager interface.

When a module exports this function and it returns OK, Module Gateway forwards the received command to the device immediately upon receipt, without waiting for the next status message. If the function is not exported, Module Gateway defaults to NOT_OK - preserving the existing on-next-status behaviour.

Implemented to support BAF-1562 (Teleop Control bridge), where commands must reach the device within 100 ms end-to-end and cannot wait for the next periodic status cycle.

…face

- introduces forward_command_on_receive(unsigned int device_type) as an optional export
- returning OK signals MG to forward the received command to the device immediately, without waiting for the next status
- if not exported by the module, MG defaults to NOT_OK (existing on-next-status behaviour)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Warning

Review limit reached

@danprudky, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 39 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ac64e5ec-b75b-4e62-8dfa-9db97f467362

📥 Commits

Reviewing files that changed from the base of the PR and between c9d33f1 and 8440d84.

📒 Files selected for processing (1)
  • lib/module_maintainer/module_gateway/include/fleet_protocol/module_maintainer/module_gateway/module_manager.h
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BAF-1204/Teleoperation-Control

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danprudky danprudky requested a review from jiriskuta June 2, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant