Skip to content

👷 Update workflows to use brixion-runner for Github Actions#18

Merged
rickyheijnen merged 1 commit into
mainfrom
setup/use-brixion-runners
Aug 13, 2025
Merged

👷 Update workflows to use brixion-runner for Github Actions#18
rickyheijnen merged 1 commit into
mainfrom
setup/use-brixion-runners

Conversation

@rickyheijnen

Copy link
Copy Markdown
Member

🔍 Samenvatting

Deze PR past de runs-on in de workflows aan naar brixion-runners zodat onze eigen Github Action runners worden gebruikt.

✅ Checklist

  • Code is lokaal getest
  • Tests zijn toegevoegd/aangepast
  • Documentatie bijgewerkt (indien nodig)

@rickyheijnen
rickyheijnen requested a review from LegeBeker August 13, 2025 20:02
@rickyheijnen rickyheijnen self-assigned this Aug 13, 2025
@rickyheijnen rickyheijnen added the type: 👷 ci GitHub Actions implementation label Aug 13, 2025
@rickyheijnen
rickyheijnen enabled auto-merge (squash) August 13, 2025 20:02
@coderabbitai

coderabbitai Bot commented Aug 13, 2025

Copy link
Copy Markdown

Walkthrough

Updated GitHub Actions workflows to use the brixion-runners label instead of self-hosted for label-sync and lint-markdown jobs. No other workflow steps or logic changed.

Changes

Cohort / File(s) Change summary
GitHub Actions runner label update
.github/workflows/label-sync.yml, .github/workflows/lint-markdown.yml
Switched job runner label from self-hosted to brixion-runners; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

type: ci

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch setup/use-brixion-runners

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
.github/workflows/lint-markdown.yml (1)

14-14: Align with self-hosted label best practice and fix actionlint warning

Mirror the approach in label-sync: include 'self-hosted' along with your custom label to be explicit, and keep actionlint happy by adding the custom label to its config (see prior comment).

Apply this diff:

-        runs-on: brixion-runners
+        runs-on:
+          - self-hosted
+          - brixion-runners
🧹 Nitpick comments (2)
.github/workflows/label-sync.yml (1)

11-75: Optional hardening: set minimal token permissions and a job timeout

Label sync requires issues:write (for labels). Explicit permissions prevent privilege creep and avoid surprises if org defaults change. A timeout guards against stuck jobs on self-hosted runners.

Add under the workflow root:

permissions:
  contents: read
  issues: write

And for the job:

jobs:
  label-sync:
    timeout-minutes: 15
.github/workflows/lint-markdown.yml (1)

11-33: Optional: add a job timeout

Self-hosted jobs can hang; set a conservative timeout.

jobs:
  lint-markdown:
    timeout-minutes: 10
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2398856 and fa27341.

📒 Files selected for processing (2)
  • .github/workflows/label-sync.yml (1 hunks)
  • .github/workflows/lint-markdown.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/lint-markdown.yml

14-14: label "brixion-runners" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

.github/workflows/label-sync.yml

10-10: label "brixion-runners" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

Comment thread .github/workflows/label-sync.yml
@rickyheijnen
rickyheijnen merged commit 9c7942c into main Aug 13, 2025
1 of 3 checks passed
@rickyheijnen
rickyheijnen deleted the setup/use-brixion-runners branch August 13, 2025 20:48
@coderabbitai coderabbitai Bot mentioned this pull request Aug 26, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: 👷 ci GitHub Actions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants