👷 Update workflows to use brixion-runner for Github Actions#18
Conversation
WalkthroughUpdated GitHub Actions workflows to use the brixion-runners label instead of self-hosted for label-sync and lint-markdown jobs. No other workflow steps or logic changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.github/workflows/lint-markdown.yml (1)
14-14: Align with self-hosted label best practice and fix actionlint warningMirror the approach in label-sync: include 'self-hosted' along with your custom label to be explicit, and keep actionlint happy by adding the custom label to its config (see prior comment).
Apply this diff:
- runs-on: brixion-runners + runs-on: + - self-hosted + - brixion-runners
🧹 Nitpick comments (2)
.github/workflows/label-sync.yml (1)
11-75: Optional hardening: set minimal token permissions and a job timeoutLabel sync requires issues:write (for labels). Explicit permissions prevent privilege creep and avoid surprises if org defaults change. A timeout guards against stuck jobs on self-hosted runners.
Add under the workflow root:
permissions: contents: read issues: writeAnd for the job:
jobs: label-sync: timeout-minutes: 15.github/workflows/lint-markdown.yml (1)
11-33: Optional: add a job timeoutSelf-hosted jobs can hang; set a conservative timeout.
jobs: lint-markdown: timeout-minutes: 10
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/label-sync.yml(1 hunks).github/workflows/lint-markdown.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/lint-markdown.yml
14-14: label "brixion-runners" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/label-sync.yml
10-10: label "brixion-runners" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🔍 Samenvatting
Deze PR past de
runs-onin de workflows aan naarbrixion-runnerszodat onze eigen Github Action runners worden gebruikt.✅ Checklist