Update gist posting to work with the lastest changes to gist.github.com#104
Open
nilbus wants to merge 4 commits intobrotherbard:experimentalfrom
SciMed:experimental
Open
Update gist posting to work with the lastest changes to gist.github.com#104nilbus wants to merge 4 commits intobrotherbard:experimentalfrom SciMed:experimental
nilbus wants to merge 4 commits intobrotherbard:experimentalfrom
SciMed:experimental
Conversation
No authentication support yet; that will require using OAuth2 tokens. Better logging. Keep multiple -s from showing up in patch filenames.
Using cookies for token storage. Made the gist description more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a more generic regex to find the gist id. The old regex was failing because github no longer considers this HTTP request to be logged in, despite having the API token, so it does not provide an edit button.
Github now expects the parameter action_button=private, instead of private=true. All gists were being created as public gists.
The "TODO: Replace true with private preference" comment was outdated, since this has since been done.
Note: This patch does not require GitX to be rebuilt. The updated history.js file can be dropped into an existing GitX installation at /Applications/GitX.app/Contents/Resources/html/views/history/history.js and it will go into effect after restarting GitX. The GitX download for SciMed/gitx contains this patch.