Minor tweaks to commit line drawing#74
Open
lilyball wants to merge 1 commit intobrotherbard:experimentalfrom
Open
Minor tweaks to commit line drawing#74lilyball wants to merge 1 commit intobrotherbard:experimentalfrom
lilyball wants to merge 1 commit intobrotherbard:experimentalfrom
Conversation
Author
|
Hrm, apparently pushing a new commit automatically adds it to the existing pull request. That's kinda neat, but also unexpected. |
The conventional git commit message styling says to limit your first line to roughly 50 characters, and subsequent lines to 76 characters. The column guide in GitX doesn't support this. Implement 2 new hidden preferences, one to determine whether it uses a split column guide and the other to set the length of this guide. Default these preferences to NO and 76, respectively. When the split column guide is turned on, the drawing code will draw the normal column guide only for the first line and it will use the split column guide length for every other line.
Author
|
Looks like you pulled in the first commit at some point. Any chance of pulling in the second? I still needs an actual GUI preference, but I don't see why that has to hold up adding the functionality. I've had to distribute my custom build of GitX to everyone in the office instead of letting them download yours because of this. |
kelan
pushed a commit
to kelan/gitx
that referenced
this pull request
May 15, 2017
Show stash contents when selected in the sidebar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is unambiguously correct. It cleans up the column guide drawing code to draw the line more accurately (instead of 5 pixels off, as it is right now) and to stop relying on the dirty rect as part of its positioning code.
The second commit is something that I really like. It adds the ability to have two separate column guides, one for the first line and one for all subsequent lines. Right now this is kept as a hidden preference that defaults to off, but if accepted then it should be added to the preferences window.