Skip to content

Fix bug when using 'latest' version on macOS #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davertay wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix bug when using 'latest' version on macOS #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/snapshot_installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ export class SnapshotInstaller implements Installer {
): Promise<InstallResult | undefined> {
const root = await cache.find("chromium", version);
if (root) {
return { root, bin: "chrome" };
const bin = this.platformChromeBin();
return { root, bin };
}
}

Expand All @@ -40,16 +41,7 @@ export class SnapshotInstaller implements Installer {
return path.join(extPath, "chrome-win");
}
})();
const bin = (() => {
switch (this.platform.os) {
case OS.DARWIN:
return "Chromium.app/Contents/MacOS/Chromium";
case OS.LINUX:
return "chrome";
case OS.WINDOWS:
return "chrome.exe";
}
})();
const bin = this.platformChromeBin();

root = await cache.cacheDir(root, "chromium", version);
core.info(`Successfully Installed chromium to ${root}`);
Expand Down Expand Up @@ -104,4 +96,15 @@ export class SnapshotInstaller implements Installer {

return { root, bin };
}

platformChromeBin = () => {
switch (this.platform.os) {
case OS.DARWIN:
return "Chromium.app/Contents/MacOS/Chromium";
case OS.LINUX:
return "chrome";
case OS.WINDOWS:
return "chrome.exe";
}
}
}