Restore Chromium profile detection paths in daemon#160
Restore Chromium profile detection paths in daemon#160VF-AdminOver wants to merge 2 commits intobrowser-use:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32b9b4cb96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| original_handler = self.cdp._event_registry.handle_event | ||
| self._original_handler = original_handler | ||
| mark_js = "if(!document.title.startsWith('\\U0001F7E2'))document.title='\\U0001F7E2 '+document.title" |
There was a problem hiding this comment.
This string now double-escapes the Unicode codepoint, so the browser receives \U0001F7E2 literally and prefixes U0001F7E2 instead of the intended 🟢 indicator. In practice this regresses tab-marking behavior: helpers.py still marks/unmarks using the real emoji, so after navigations or session changes the daemon’s prefix and helper cleanup no longer match, leaving stale/incorrect tab titles.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="daemon.py">
<violation number="1" location="daemon.py:192">
P2: Double-escaped Unicode marker breaks title emoji tagging logic; JS receives literal `\U0001F7E2` text instead of 🟢.</violation>
<violation number="2" location="daemon.py:256">
P2: Same double-escaped Unicode issue here: `'\\U0001F7E2'` sends the literal text `\U0001F7E2` to the browser instead of the 🟢 emoji. Use the single-backslash form so Python resolves it to the real character.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
VF-AdminOver
force-pushed
the
fix/restore-chromium-brave-detection
branch
from
32b9b4c to
8e98c02
Compare
1 participant
Summary
Details
PROFILES:~/.config/chromium~/.config/chromium-browser~/AppData/Local/Chromium/User DataValidation
python3 -m py_compile daemon.pyThis addresses the automation review regression where Chromium browser autodiscovery could fail while docs still claim Chromium support.
Summary by cubic
Restored and expanded profile autodiscovery for Chromium-based browsers to fix local attach across Chrome, Chromium, Brave, and Edge. Also improved CDP attach robustness, event handling, shutdown, and error messages.
Bug Fixes
Chromiumpath.Target.*behavior (no session) and auto‑reattach on stale sessions.wait_closed; remove PID and SOCK).Refactors
stop_event, explicit CDP stop, and restore original event handler.Written for commit 8e98c02. Summary will update on new commits.