fix(helpers): resolve domain skills for subdomains and hyphenated hosts#165
Open
hnshah wants to merge 1 commit intobrowser-use:mainfrom
Open
fix(helpers): resolve domain skills for subdomains and hyphenated hosts#165hnshah wants to merge 1 commit intobrowser-use:mainfrom
hnshah wants to merge 1 commit intobrowser-use:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goto()extracts domain skills by taking the first segment of the hostname (booking.com→booking). This misses:booking.com→ folder isbooking-com, notbookingold.reddit.com→ looks forold, should findreddititch.io→ folder isitch-io,archive.org→ folder isarchive-orgAdded
_skill_dir()which tries a fallback chain:old.reddit.com→ tryold, thenreddit, thencom)booking.com→booking-com)Before / after
booking.combooking(missing)booking-comold.reddit.comold(missing)reddititch.ioitch(missing)itch-ioarchive.orgarchive(missing)archive-orgreddit.comredditreddit(unchanged)github.comgithubgithub(unchanged)Test plan
_skill_dir()against 11 URLs covering all casesgoto("https://www.booking.com")— returnsdomain_skills: ["scraping.md"]goto("https://old.reddit.com")— returnsdomain_skills: ["scraping.md"]github.com,reddit.com,stackoverflow.com) still resolve correctlySummary by cubic
Fixes domain-skill resolution in
goto()to correctly handle subdomains and hyphenated or multi-segment hosts. Adds_skill_dir()with a fallback search over hostname segments and the hyphenated full host.old.reddit.com→reddit).booking.com→booking-com,itch.io→itch-io).domain_skillsonly when a matching folder exists; otherwise response is unchanged.Written for commit a9299f7. Summary will update on new commits.