fix(deps): pin websockets==15.0.1 to unblock Chrome 147 CDP handshake#172
Open
mvanhorn wants to merge 1 commit intobrowser-use:mainfrom
Open
fix(deps): pin websockets==15.0.1 to unblock Chrome 147 CDP handshake#172mvanhorn wants to merge 1 commit intobrowser-use:mainfrom
mvanhorn wants to merge 1 commit intobrowser-use:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #106,
websockets==16.0sendsSec-WebSocket-Extensions: permessage-deflate; client_max_window_bitsduring the WebSocket upgrade. Chrome 147's CDP endpoint rejects this header and closes the connection (EOF after ~7 bytes). Browser-harness becomes unusable out of the box on Chrome 147 as a result.Change
pyproject.toml:websockets==16.0->websockets==15.0.1. That is the full diff.Why 15.0.1 is safe
cdp-use==1.4.5declaresRequires-Dist: websockets>=15.0.1, so the floor is satisfied. No cdp-use API is dropped.websocketsCVEs (GHSA-6g87-ff9q-v847, GHSA-8ch4-58qp-g3mp, PYSEC-2018-79, PYSEC-2021-95) were fixed at or before version 9.1. Rolling back from 16.0 to 15.0.1 drops no security fix.What this does NOT do
cdp-use==1.4.5orfetch-use==0.4.0pinscompression=Nonetowebsockets.connect()). That belongs in cdp-use, not here.Relationship to #142 and #102
PR #142 is fixing
Fixes #107, #123and isRelated to #106, but #142 addresses the Chrome 147 profile-directory block, not the handshake-header path. Both land on the same "Chrome 147 breaks this" symptom from different root causes. This PR is the complementary fix. Both can merge independently.Local verification
Fresh venv, install from this branch:
uv.lockis gitignored upstream, so no lock-file diff lands in this PR.Fixes #106
Summary by cubic
Pin
websocketsto15.0.1to restore the Chrome 147 CDP handshake by avoiding thepermessage-deflateheader sent by16.0. Unblocks the browser harness on Chrome 147. Fixes #106.pyproject.toml: changewebsocketsfrom16.0to15.0.1.cdp-use==1.4.5; no other pins changed.Written for commit 4faf1d7. Summary will update on new commits.