Add macOS Brave profile path + port-9222/9223 CDP probe fallback#173
Open
drichman1-maker wants to merge 1 commit intobrowser-use:mainfrom
Open
Add macOS Brave profile path + port-9222/9223 CDP probe fallback#173drichman1-maker wants to merge 1 commit intobrowser-use:mainfrom
drichman1-maker wants to merge 1 commit intobrowser-use:mainfrom
Conversation
Two small fixes in daemon.py for macOS users running Brave (or any Chromium variant launched with --remote-debugging-port): 1. PROFILES list was missing the macOS path for Brave (~/Library/Application Support/BraveSoftware/Brave-Browser). The Linux Flatpak path was the only Brave entry, so macOS Brave users got "DevToolsActivePort not found" even after enabling remote debugging. 2. When Chromium is launched with an explicit --remote-debugging-port flag, the DevToolsActivePort file is not always written to the profile dir. CDP is fully live, but get_ws_url() can't find it. Added a final fallback that probes 127.0.0.1:9222 and :9223 via /json/version and uses the returned webSocketDebuggerUrl. The loop is gated to the standard debugging ports and only runs after the existing profile-dir scan fails, so it doesn't interfere with the normal sticky-checkbox flow. Both changes are additive — no existing behavior is altered.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small additive fixes in
daemon.pyso macOS users running Brave (or any Chromium variant launched with--remote-debugging-port) can attach without manualBU_CDP_WSwiring.Add macOS Brave profile path to
PROFILES. The list previously only had the Linux Flatpak path for Brave (~/.var/app/com.brave.Browser/...), so macOS Brave users hitDevToolsActivePort not foundeven with the sticky inspect checkbox enabled. Adds~/Library/Application Support/BraveSoftware/Brave-Browser.Probe
127.0.0.1:9222/:9223/json/versionas a final fallback inget_ws_url(). When Chromium is launched with an explicit--remote-debugging-portflag,DevToolsActivePortis not always written to the profile dir — CDP is fully live but the existing scan misses it. The fallback runs only after the profile-dir scan fails, and is gated to the standard debugging ports, so the normal sticky-checkbox flow is unaffected.Both changes are additive — no existing behavior is altered.
Test plan
open -a "Brave Browser" --args --remote-debugging-port=9222and noDevToolsActivePortfile present,browser-harness <<<'print(page_info())'attaches to the running browser via the new probe fallback.🤖 Generated with Claude Code
Summary by cubic
Enable automatic CDP attachment for macOS Brave and Chromium launched with
--remote-debugging-port, removing the need to setBU_CDP_WS. Adds a macOS Brave profile path and a last-resort probe of ports 9222/9223; existing flows stay the same.~/Library/Application Support/BraveSoftware/Brave-Browser.DevToolsActivePortis found, probehttp://127.0.0.1:9222/json/versionand:9223and usewebSocketDebuggerUrl.Written for commit 704b1d4. Summary will update on new commits.