fix: support stdin scripts and preserve JS IIFE returns#196
Open
Lhy099 wants to merge 2 commits intobrowser-use:mainfrom
Open
fix: support stdin scripts and preserve JS IIFE returns#196Lhy099 wants to merge 2 commits intobrowser-use:mainfrom
Lhy099 wants to merge 2 commits intobrowser-use:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="helpers.py">
<violation number="1" location="helpers.py:213">
P2: Broad string matching for retry can re-run side-effectful JS when unrelated runtime errors include "Illegal return statement".</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
234b54f to
9b9fb48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Adds stdin/heredoc script support to
browser-harnesswhen no-cis provided. Tightenshelpers.js()to only auto-wrap on "Illegal return statement" when it’s a SyntaxError, preserving valid IIFE return values.New Features
browser-harnessexecutes code from stdin when run with no args.-cbehavior is unchanged and never reads stdin.Bug Fixes
helpers.js()retries with an IIFE only when "Illegal return statement" is a SyntaxError; runtime Error messages are not retried.Written for commit 9b9fb48. Summary will update on new commits.