fix(tui): never pass to macos opener#111
Open
laithrw wants to merge 2 commits into
Open
Conversation
…ener - request_open_browser dropped its literal about:blank fallback; with no live/page url it now shows a notice instead of shelling out - open_external_url validates targets via new external_browser_target(): only http(s)/file urls reach open::that_detached; about:/chrome:// placeholders are rejected (macos can fuzzy-match junk open targets to app names, and "about*" uniquely resolves to About This Mac.app) - one test encodes the constraint; browser_panel test now seeds a real live url since the placeholder fallback is gone
laithrw
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Prevented placeholder and internal browser URLs from reaching the macOS opener, avoiding accidental “About This Mac” launches. We now validate targets and show a clear notice when no URL exists.
about:blankfallback in request_open_browser; show an inline notice when no URL exists.external_browser_targetvalidation; only http(s)/file URLs reachopen::that_detached(rejectsabout:*,chrome://*,javascript:).Written for commit 78f2628. Summary will update on new commits.